Fix potential memcpy call with null dest #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check into CCID_Receive() in commands.c that skips calling memcpy() in case the count is zero. This fixes the (theoretical) problem in case both the count and the dest pointer are zero (such a call can be made, e.g., from CmdXfrBlockAPDU_extended()) and the compiler uses the non-null argument requirement to generate some incorrect code. This potential issue was found by clang-tidy (the "NonNullParamChecker" diagnostic).
emaxx-google
force-pushed
the
clang-tidy--memcpy-null
branch
from
4f834fc
to
e7b2149
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check into CCID_Receive() in commands.c that skips calling
memcpy() in case the count is zero. This fixes the (theoretical) problem
in case both the count and the dest pointer are zero (such a call can be
made, e.g., from CmdXfrBlockAPDU_extended()) and the compiler uses the
non-null argument requirement to generate some incorrect code.
This potential issue was found by clang-tidy (the "NonNullParamChecker"
diagnostic).