Fix random order of interfaces in OpenUSBByName(). #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of static_interface should be increased for composite devices only.
|
The value of Please describe in details the problem your patch is trying to fix. |
|
The value of static_interface will be increased if the reader have single interface or multiple interfaces. e.g. static_interface becomes 2 if the reader with single interface is plugged. Then, the driver opens the 2nd interface first if the reader with multiple interfaces is plugged. |
LudovicRousseau
pushed a commit
that referenced
this pull request
Jun 23, 2016
The value static_interface shall be incremented only for composite devices. Otherwise any other reader would increase the value and the next composite reader connected will have its interfaces enumerated in a different order. The problem occurs only on Mac OS X (pcscd) that still does not support composite CCID devices. The CCID driver has to be configured with --enable-composite-as-multislot and composite CCID devices are "emulated" as a multi-slot device. Thanks to Godfrey Chung for the patch #19
|
Fixed in 6123a4c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of static_interface should be increased for composite devices
only.