commands: CmdPowerOn: Fix nlength return value in overflow case #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CmdPowerOn is supposed to return ATR and its length in buffer/nlength. A bounds check is performed in the code, and truncates atr_len to the length of the received data (minus 10 bytes for the header). However, in that case, nlength in not updated, leading to a returned ATR with trailing garbage. This is an edge, error case, that should never happen, and was introduced while fixing a potentially more serious buffer overrun in 2020. Fixes: a382095 ("CmdPowerOn: fix a potention overrun with bogus ATR")
|
Fixed in ba4775a Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CmdPowerOn is supposed to return ATR and its length in buffer/nlength.
A bounds check is performed in the code, and truncates atr_len to the length of the received data (minus 10 bytes for the header). However, in that case, nlength in not updated, leading to a returned ATR with trailing garbage.
This is an edge, error case, that should never happen, and was introduced while fixing a potentially more serious buffer overrun in 2020.
Fixes: a382095 ("CmdPowerOn: fix a potention overrun with bogus ATR")