Fix InterruptStop if called before InterruptRead #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to make the polling termination (via TAG_IFD_STOP_POLLING_THREAD) actually work even when it's triggered before the InterruptRead has a chance to create and publish the polling_transfer. Without this patch, in some cases the termination was blocked for 10 minutes, because the thread that does InterruptStop might still see the null polling_transfer meanwhile the other thread is about to start this transfer. The proposed solution is to remember in a separate (atomic) boolean flag whether the termination started, to avoid this kind of race condition.
emaxx-google
added a commit
to GoogleChromeLabs/chromeos_smart_card_connector
that referenced
this pull request
Sep 27, 2023
Apply the fix that was submitted upstream: LudovicRousseau/CCID#116. This fixes #1078.
emaxx-google
added a commit
to GoogleChromeLabs/chromeos_smart_card_connector
that referenced
this pull request
Sep 28, 2023
Apply the fix that was submitted upstream: LudovicRousseau/CCID#116. This fixes #1078.
|
Sorry, this change was incorrect. We should allow starting a new polling transfer after the previous one has been stopped. I've published an attempt to fix this problem: #119; alternatively, this PR needs to be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make the polling termination (via
TAG_IFD_STOP_POLLING_THREAD) actually work even when it's triggered before the InterruptRead has a chance to create and publish the polling_transfer.
Without this patch, in some cases the termination was blocked for 10 minutes, because the thread that does InterruptStop might still see the null polling_transfer meanwhile the other thread is about to start this transfer. The proposed solution is to remember in a separate (atomic) boolean flag whether the termination started, to avoid this kind of race condition.