Skip to content

Commit

Permalink
Disable pinpad for Chicony HP Skylab USB Smartcard Keyboard
Browse files Browse the repository at this point in the history
Chicony HP Skylab Smartcard Keyboard have symptoms similar to other HP
keyboards - USB descriptor advertises pinpad support but no pinpad is
actually available, causing PIN entry to fail.
Disabling pinpad fixes the problem.
  • Loading branch information
erkia authored and LudovicRousseau committed Feb 21, 2020
1 parent 3631363 commit 84c1bca
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/ccid.c
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ int ccid_open_hack_post(unsigned int reader_index)
case HPSMARTCARDKEYBOARD:
case HP_CCIDSMARTCARDKEYBOARD:
case FUJITSUSMARTKEYB:
case CHICONYHPSKYLABKEYBOARD:
/* the Secure Pin Entry is bogus so disable it
* https://web.archive.org/web/20120320001756/http:https://martinpaljak.net/2011/03/19/insecure-hp-usb-smart-card-keyboard/
*
Expand Down
1 change: 1 addition & 0 deletions src/ccid.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ typedef struct
#define VEGAALPHA 0x09820008
#define HPSMARTCARDKEYBOARD 0x03F01024
#define HP_CCIDSMARTCARDKEYBOARD 0x03F00036
#define CHICONYHPSKYLABKEYBOARD 0x04F21469
#define KOBIL_IDTOKEN 0x0D46301D
#define FUJITSUSMARTKEYB 0x0BF81017
#define FEITIANR502DUAL 0x096E060D
Expand Down

0 comments on commit 84c1bca

Please sign in to comment.