Run pre-commit hooks on CI #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the huge effort maintaining the best dashboard out there.
Background
I've been using the lovely dashboard for few weeks (since I discovered it) and I got impressed by the quality of this work and wanted to contributed somehow. I popped by GitHub and found the repo, so I looked for something that may be helpful for you.
Goal
The goal is to run the pre-commit hooks within CI for a fast check of the code contributions. Although, the pre-commits are intended for an early stage (before CI) it may be helpful for a quick check and also to run those automatically before merging the PRs. This also may enable you to merge PRs without pulling the code and running the hooks on your own.
You can check a working example here
Last but not least, feel free to discard this PR if you don't find it useful for you, I'll check out how to contribute in another way that may be more helpful.
Thanks!