Fix CPD Manifest's partition offset #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header size needs to be probably added here, maybe it was forgotten ? This is needed in order to get the proper base address of a CPD_EXT_IFWI_PARTITION_MANIFEST structure in the image for example in that specific case. If I don't do this, it points to a meaningless address. Let me know if there can be any issues with this.
|
Sorry, but I just noticed that it does indeed make a problem, FTPR.man does not point anymore to the right base address, I think the header size will likely be needed to be added on the offset field in the Types::CpdExtension. I'll make another pull request to revert this and fix it again |
|
For future similar changes let's start with a GH issue with files and screenshots demonstrating the problem, will be easier to prevent multiple fixes for the same problem this way. |
I'll do that, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header size needs to be probably added here, maybe it was forgotten ?
This is needed in order to get the proper base address of a CPD_EXT_IFWI_PARTITION_MANIFEST structure in the image for example in that specific case.
If I don't do this, it points to a meaningless address.
Let me know if there can be any issues with this.