Fix for AMI NVAR parser based on kaitai struct #373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify 1 line in ami_nvar.ksy (line 128).
Bug scenario:
nvar_entry.attributes.valid = 0
nvar_entry.attributes.extended_header = 1
Now, extended_header_size_field 's value is undefined, as defined in ami_nvar.ksy
but this value would be used by other instances, e.g. extended_header_size, as defined in ami_nvar.ksy
finally leads to parse error/exception or program crash.