Add infinite mode #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
|
|
||
| public static Piece[] validateBlock(Piece[] holder, Board board) { | ||
| long invocationTime = System.nanoTime(); | ||
| State initialState = new State(board); |
There was a problem hiding this comment.
Hm, we're rebuilding the entire state every time we need to validate a piece instead of keeping it in synchrony with the board itself. Though it's true this is only ran when more pieces are needed and that's not common, so I believe it's okay.
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
Lonami
reviewed
Oct 20, 2018
|
Despite the fact you should reformat the file so the style is consistent, the code itself looks alright. A bit too much of copy-pasting from |
|
Regarding the icons, those are no problem. I can add them with the rest at https://github.com/LonamiWebs/Klooni1010/blob/master/original-resources/buttons.svg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the infinite mode I had referenced in issue #51. Could you please review it?
Also, I had a bit of hard time figuring out how to create icons with Photoshop, and infinite marks are not naturally square-shaped. To indicate that player was using infinite mode, I decided to change the game over reason to "made wrong move" since we can assume that's what happened.