Add missing attribute #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokathor
approved these changes
May 14, 2024
|
Just yesterday and today I started to properly work on getting a 0.12 version of the gba crate itself together. The big difference is that I'll be avoiding nightly features other than build-std, so I've had to replace naked functions with global asm and stuff like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute was missing on the second version, I ended up copying this part directly and got really confused why mgba was rejecting it, turns out I missed this line and it ended up generating thumb code, oops.
And huge thanks for writing this, I wanted to get a bare minimum gba game building in rust but I wanted to really understand what's going on with that assembly and linker magic, this satisfied my curiosity, looking forward for more.