Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Roots\public_path() #17

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

cleverington
Copy link
Contributor

Also included helpful flavor-text, as it took me a minute to "get it working" properly, because one of the online flavor help-notes I found said to use public/images/icons/ instead! :D

Vaguely related to #11, but not sure there's an issue for the deprecation.

image

image

Also included helpful flavor-text, as it took me a minute to "get it working" properly, because one of the online flavor help-notes I found said to use `public/images/icons/` instead! :D 

Vaguely related to Log1x#11
@Log1x
Copy link
Owner

Log1x commented Apr 12, 2023

We still want to use public_path() - the only thing deprecated is using with the Roots\ namespace.

If you want, change it back to public_path(), remove the extra docblock (as public path should be pretty straight forward), and remove the use function Roots\public_path at the top.

@Log1x Log1x merged commit b01ea53 into Log1x:master Jul 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants