fix(a11y): set aria-hidden on prev/next link text #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these have a label we need to hide the text content which is used as the label. Right now these announce both the `aria-label` and the text content. It could be tempting to wrap the arrows with a span with `aria-hidden=true` on it and then add a visually hidden span with "Page" in it, but that would probably suffer from screen readers fragmenting the text.
knowler
deleted the
hide-labelled-link-text-content-from-screen-reader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these have a label we need to hide the text content which is used as the label. Right now these announce both the
aria-labeland the text content.