Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upnp): Support miniupnpc API version 18 (release 2.2.8) #2746

Closed
wants to merge 1 commit into from

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Jun 23, 2024

Description

The miniupnpc API has changed slightly. This allows both older and newer versions. The additional arguments are for returning data that Sunshine doesn't need to care about, so nullptr, 0 is sufficient. I have already made the same change to a couple of other projects.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

src/upnp.cpp Show resolved Hide resolved
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.95%. Comparing base (90fd371) to head (09b7ac3).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2746      +/-   ##
=========================================
- Coverage    8.95%   8.95%   -0.01%     
=========================================
  Files          94      94              
  Lines       17383   17385       +2     
  Branches     8267    8267              
=========================================
  Hits         1557    1557              
- Misses      12962   12967       +5     
+ Partials     2864    2861       -3     
Flag Coverage Δ
Linux 6.79% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 10.01% <ø> (-0.02%) ⬇️
macOS-13 9.92% <ø> (-0.01%) ⬇️
macOS-14 10.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/upnp.cpp 2.98% <ø> (-0.04%) ⬇️

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants