Add type assertion to inner HermOrSym constructor (JuliaLang#50282)

Liozou · Jun 26, 2023 · d01b8cd · d01b8cd
1 parent ed338d0
commit d01b8cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/stdlib/LinearAlgebra/src/symmetric.jl b/stdlib/LinearAlgebra/src/symmetric.jl
@@ -5,7 +5,7 @@ struct Symmetric{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T}
  data::S
  uplo::Char
 
- function Symmetric{T,S}(data, uplo) where {T,S<:AbstractMatrix{<:T}}
+ function Symmetric{T,S}(data, uplo::Char) where {T,S<:AbstractMatrix{<:T}}
  require_one_based_indexing(data)
  (uplo != 'U' && uplo != 'L') && throw_uplo()
  new{T,S}(data, uplo)
@@ -98,7 +98,7 @@ struct Hermitian{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T}
  data::S
  uplo::Char
 
- function Hermitian{T,S}(data, uplo) where {T,S<:AbstractMatrix{<:T}}
+ function Hermitian{T,S}(data, uplo::Char) where {T,S<:AbstractMatrix{<:T}}
  require_one_based_indexing(data)
  (uplo != 'U' && uplo != 'L') && throw_uplo()
  new{T,S}(data, uplo)

diff --git a/stdlib/LinearAlgebra/test/symmetric.jl b/stdlib/LinearAlgebra/test/symmetric.jl
@@ -64,6 +64,9 @@ end
  @test_throws ArgumentError Symmetric(asym, :R)
  @test_throws ArgumentError Hermitian(asym, :R)
 
+ @test_throws MethodError Symmetric{eltya,typeof(asym)}(asym, :L)
+ @test_throws MethodError Hermitian{eltya,typeof(aherm)}(aherm, :L)
+
  # mixed cases with Hermitian/Symmetric
  if eltya <: Real
  @test Symmetric(Hermitian(aherm, :U)) === Symmetric(aherm, :U)