Skip to content

Commit

Permalink
Fix typo/boolean usage in stream eof comments (JuliaLang#46504)
Browse files Browse the repository at this point in the history
Co-authored-by: Jameson Nash <[email protected]>
  • Loading branch information
quinnj and vtjnash committed Nov 3, 2022
1 parent d9bcc5f commit b382456
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/stream.jl
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function eof(s::LibuvStream)
bytesavailable(s) > 0 && return false
wait_readnb(s, 1)
# This function is race-y if used from multiple threads, but we guarantee
# it to never return false until the stream is definitively exhausted
# it to never return true until the stream is definitively exhausted
# and that we won't return true if there's a readerror pending (it'll instead get thrown).
# This requires some careful ordering here (TODO: atomic loads)
bytesavailable(s) > 0 && return false
Expand Down

0 comments on commit b382456

Please sign in to comment.