Make median! type stable for small float types (JuliaLang#29902)

Fixed JuliaLang#29900
Liozou · Nov 5, 2018 · 5c464e9 · 5c464e9
1 parent 1f2b16f
commit 5c464e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/stdlib/Statistics/src/Statistics.jl b/stdlib/Statistics/src/Statistics.jl
@@ -694,7 +694,7 @@ Like [`median`](@ref), but may overwrite the input vector.
 function median!(v::AbstractVector)
  isempty(v) && throw(ArgumentError("median of an empty array is undefined, $(repr(v))"))
  eltype(v)>:Missing && any(ismissing, v) && return missing
- (eltype(v)<:AbstractFloat || eltype(v)>:AbstractFloat) && any(isnan, v) && return NaN
+ (eltype(v)<:AbstractFloat || eltype(v)>:AbstractFloat) && any(isnan, v) && return convert(eltype(v), NaN)
  inds = axes(v, 1)
  n = length(inds)
  mid = div(first(inds)+last(inds),2)

diff --git a/stdlib/Statistics/test/runtests.jl b/stdlib/Statistics/test/runtests.jl
@@ -57,6 +57,11 @@ end
  @test median!([1 2; 3 4]) == 2.5
 
  @test invoke(median, Tuple{AbstractVector}, 1:10) == median(1:10) == 5.5
+
+ @test @inferred(median(Float16[1, 2, NaN])) === Float16(NaN)
+ @test @inferred(median(Float16[1, 2, 3])) === Float16(2)
+ @test @inferred(median(Float32[1, 2, NaN])) === NaN32
+ @test @inferred(median(Float32[1, 2, 3])) === 2.0f0
 end
 
 @testset "mean" begin