Pin SQLAlchemy to at least v1.4 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Inspector.has_table` doesn't exist until version 1.4. (note: on versions below 1.4 we could use `Engine.has_table` instead)
yifanwu
approved these changes
Jul 20, 2022
| @@ -43,7 +43,7 @@ def version(path): | |||
| minimal_requirement = [ | |||
| "click>=8.0.0", | |||
| "pydantic", | |||
| "SQLAlchemy", | |||
| "SQLAlchemy>=1.4", | |||
There was a problem hiding this comment.
Sometimes we also need to update requirements.txt when changing setup.py, but seems like the requirements.txt is already compliant
https://github.com/LineaLabs/lineapy/blob/main/requirements.txt#L42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LIN-496
Inspector.has_tabledoesn't exist until version 1.4.(note: on versions below 1.4 we could use
Engine.has_tableinstead)Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?