Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIN-483 Add version options to lineapy cli #723

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

andycui97
Copy link
Contributor

Summary:
This commit adds a '-v' and '--version' flags to Lineapy CLI.
These options print the package name and version when supplied.

Test Plan:
Local testing.

(linea-venv-3.9.0) Lineas-MacBook-Pro:~ andrewcui$ lineapy -v
lineapy 0.1.4

(linea-venv-3.9.0) Lineas-MacBook-Pro:~ andrewcui$ lineapy --version
lineapy 0.1.4

JIRA:
LIN-483

Summary:
This commit adds a '-v' and '--version' flags to Lineapy CLI.
These options print the package name and version when supplied.

Test Plan:
Local testing.

> (linea-venv-3.9.0) Lineas-MacBook-Pro:~ andrewcui$ lineapy -v
> lineapy 0.1.4

> (linea-venv-3.9.0) Lineas-MacBook-Pro:~ andrewcui$ lineapy --version
> lineapy 0.1.4

JIRA:
LIN-483
@andycui97 andycui97 changed the title Add version options to lineapy cli LIN-483 Add version options to lineapy cli Jul 13, 2022
@andycui97
Copy link
Contributor Author

Clarifying comments on why we want to specify "-v" and "--version" explicitly:

The documentation says
https://click.palletsprojects.com/en/8.1.x/api/

param_decls (str) – One or more option names. Defaults to the single value "--version".

Opting to specify both since we want both.

Copy link
Contributor

@lionsardesai lionsardesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@andycui97 andycui97 merged commit bbc5c3a into main Jul 13, 2022
@andycui97 andycui97 deleted the LIN-483-cliversion branch July 13, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants