-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates all scripts to LARS #613
Conversation
Hello @ananyahjha93! Thanks for updating this PR.
Comment last updated at 2021-04-12 18:22:08 UTC |
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 25.20% 25.44% +0.24%
==========================================
Files 118 118
Lines 7119 7098 -21
==========================================
+ Hits 1794 1806 +12
+ Misses 5325 5292 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Borda some test from igpt model is failing! iGPT code is still using old version of Lightning's method: I don't think this sends the metric to
|
fyi, truing to resolve the strangely failing tests in #618 |
What does this PR do?
Updates all scripts to Optimizer class version of LARS and solves the warmup + decay indexing issue.
Fixes #609
fixes #562.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃