-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TensorboardGenerativeModelImageSampler args #494
Update TensorboardGenerativeModelImageSampler args #494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 79.24% 79.06% -0.18%
==========================================
Files 107 102 -5
Lines 6201 5919 -282
==========================================
- Hits 4914 4680 -234
+ Misses 1287 1239 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-clem Thank you for your swift action! Would you mind having a look at the below suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-clem LGTM. Thank you!
@Borda @ananyahjha93 Should we include the tests for this class in this PR? or later in another PR? |
1bf5420
to
49a0cc8
Compare
What does this PR do?
Updates TensorboardGenerativeModelImageSampler args as discussed in #489.
Fixes #489
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃