deprecate hprams setter method #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4813 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 124 124
Lines 9295 9295
=======================================
+ Hits 8346 8608 +262
+ Misses 949 687 -262 |
justusschock
approved these changes
Nov 23, 2020
Borda
approved these changes
Nov 23, 2020
SkafteNicki
approved these changes
Nov 23, 2020
tchaton
approved these changes
Nov 23, 2020
ananyahjha93
approved these changes
Nov 23, 2020
s-rog
approved these changes
Nov 24, 2020
|
Some tests failing to download mnist... seems to be a quite common reason for abritrary failures, along with error uploading artifacts and parity issues |
|
@williamFalcon this requires your review since it touches lightning.py :) |
ydcjeff
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4543
Fixes #4333