Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate auto mode from ModelCheckpoint and EarlyStopping #4695

Merged
merged 14 commits into from
Dec 4, 2020
Merged

Deprecate auto mode from ModelCheckpoint and EarlyStopping #4695

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
37e817a
remove auto mode from callbacks
rohitgr7 Nov 16, 2020
697d718
chlog
rohitgr7 Nov 16, 2020
58ce530
remove auto mode from callbacks
rohitgr7 Nov 16, 2020
9c5162f
mode
rohitgr7 Nov 16, 2020
dbce63b
mode
rohitgr7 Nov 16, 2020
88ec5de
move back
rohitgr7 Nov 16, 2020
831f2d8
update docs
rohitgr7 Nov 16, 2020
49e487c
update docstrings
rohitgr7 Nov 16, 2020
d5354ca
docstring warning
rohitgr7 Nov 17, 2020
11ad30b
fix syntax
Borda Nov 18, 2020
b231833
Apply suggestions from code review
rohitgr7 Nov 18, 2020
cade0cb
isort
rohitgr7 Nov 18, 2020
161f232
default to 'auto'
rohitgr7 Nov 28, 2020
a64e353
syntax
rohitgr7 Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mode
  • Loading branch information
@rohitgr7 @Borda
rohitgr7 authored and Borda committed Dec 4, 2020
commit dbce63bb87f99d855433a1a42bf285d126248f3c
2 changes: 1 addition & 1 deletion pytorch_lightning/callbacks/early_stopping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def __init_monitor_mode(self):
if self.mode not in self.mode_dict and self.mode != 'auto':
if self.verbose > 0:
rank_zero_warn(
f'EarlyStopping mode {mode} is unknown, fallback to auto mode.',
f'EarlyStopping mode={self.mode} is unknown, fallback to auto mode.',
RuntimeWarning,
)
self.mode = 'auto'
Expand Down