Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix build docs + docker #16351

Merged
merged 29 commits into from
Jan 14, 2023
Merged

hotfix build docs + docker #16351

merged 29 commits into from
Jan 14, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 13, 2023

What does this PR do?

Addressing issue on master:

Unable to connect to azure.archive.ubuntu.com:http: [IP: 52.252.75.106 80]

try to use: https://github.com/readthedocs/readthedocs-docker-images

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta @tchaton

@Borda Borda added docs Documentation related ci Continuous Integration labels Jan 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to .github/workflows/docs-checks.yml.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success
build-cuda (3.9, 1.11, 11.3.1) success
build-cuda (3.9, 1.12, 11.6.1) success
build-cuda (3.9, 1.13, 11.7.1) success
build-hpu (1.5.0, 1.11.0) success
build-ipu (3.9, 1.10) success
build-NGC success
build-pl (3.9, 1.10, 11.3.1) success
build-pl (3.9, 1.11, 11.3.1) success
build-pl (3.9, 1.12, 11.6.1) success
build-pl (3.9, 1.13, 11.7.1) success
build-xla (3.7, 1.12) success

These checks are required after the changes to dockers/base-cuda/Dockerfile, dockers/base-ipu/Dockerfile, dockers/base-xla/Dockerfile, dockers/ci-runner-hpu/Dockerfile, dockers/docs/Dockerfile.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success
make-html (app) success

These checks are required after the changes to .github/workflows/docs-checks.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda marked this pull request as draft January 13, 2023 10:01
@Borda Borda marked this pull request as ready for review January 13, 2023 12:27
@Borda Borda added the priority: 1 Medium priority task label Jan 13, 2023
@Borda Borda requested review from ethanwharris and a team January 13, 2023 12:28
@mergify mergify bot added the ready PRs ready to be merged label Jan 13, 2023
@Borda Borda marked this pull request as draft January 13, 2023 12:36
@mergify mergify bot removed the ready PRs ready to be merged label Jan 13, 2023
@Borda
Copy link
Member Author

Borda commented Jan 13, 2023

Seems that the Azure mirrors are back up

@Borda Borda closed this Jan 13, 2023
@Borda Borda deleted the ci/docs branch January 13, 2023 12:47
@Borda Borda restored the ci/docs branch January 13, 2023 14:06
@Borda Borda reopened this Jan 13, 2023
@carmocca
Copy link
Contributor

I'm still seeing issues. If these changes help, I suggest we merge them.

@Borda
Copy link
Member Author

Borda commented Jan 13, 2023

I'm still seeing issues. If these changes help, I suggest we merge them.

yes that is why I reopened it, but may need some more work... 🦦

@Borda Borda marked this pull request as ready for review January 13, 2023 18:41
@mergify mergify bot added the ready PRs ready to be merged label Jan 13, 2023
@Borda Borda changed the title hotfix build docs hotfix build docs + docker Jan 13, 2023
@Borda Borda enabled auto-merge (squash) January 13, 2023 18:42
@Borda Borda merged commit 3828f52 into master Jan 14, 2023
@Borda Borda deleted the ci/docs branch January 14, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants