Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preflight bridge check #491

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Preflight bridge check #491

merged 1 commit into from
Jun 15, 2024

Conversation

thebracket
Copy link
Collaborator

Please test this (it's rebased to include the current develop) before we merge.

@thebracket
Rebase to current develop (which includes reverting this)
06d9fa7 
Interface status not being UP is no longer a blocker, it
lists the status in the log to help with diagnosis. (It turns
out that some valid configurations don't list UP at this
time).
@thebracket thebracket requested a review from rchac May 31, 2024 17:25
@thebracket thebracket changed the base branch from main to develop June 12, 2024 17:36
@thebracket
Copy link
Collaborator Author

Tests on local system (with veth devices) succeeds. With an XDP bridge enabled and a Linux bridge, it correctly disables the XDP one to avoid conflicts:

[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Interface veth_toexternal is in status: UP
[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Interface veth_tointernal is in status: UP
[2024-06-12T18:04:09Z ERROR lqosd::preflight_checks] Bridge (br0) contains both the internet and ISP interfaces, and you have the xdp_bridge enabled. This is not supported.
[2024-06-12T18:04:09Z WARN  lqosd::preflight_checks] Disabling XDP bridge
[2024-06-12T18:04:09Z WARN  lqosd::preflight_checks] XDP bridge disabled in ACTIVE config. Please fix the configuration file.
[2024-06-12T18:04:09Z INFO  lqosd::preflight_checks] Sanity checks passed

Without the bridge, it succeeds.

The interface state is informational only - it doesn't block success.

@thebracket
Copy link
Collaborator Author

It installed correctly on Payne, and ran there without issues also.

@thebracket thebracket merged commit 24f59e1 into develop Jun 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchac rchac Awaiting requested review from rchac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thebracket