Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preflight bridge check #487

Merged
merged 2 commits into from
May 30, 2024
Merged

Preflight bridge check #487

merged 2 commits into from
May 30, 2024

Conversation

thebracket
Copy link
Collaborator

Add two additional preflight checks to lqosd startup:

  • Interface(s) (two for bridge, one for on-a-stick) are checked for being UP before start. Downed interfaces will generate an error.
  • If XDP bridge is enabled, checks to see if any bridges exist that list the devices as their master. If a bridge exists, is up, and contains BOTH interfaces (one is ok - you might be doing a sandwich style setup), then a warning is emitted and the XDP bridge is disabled. This should prevent accidentally using both bridges at once.

@thebracket
Add preflight checks that interface(s) are UP. Add a check that if XDP
417b545 
bridging is enabled, there is no Linux bridge containing the listed
interfaces. If the interfaces are enabled, warnings are emitted and
the XDP bridge disabled to operate in Linux mode.
@thebracket
Missing doc block
cc6d9d2
@thebracket thebracket added the enhancement New feature or request label May 20, 2024
@thebracket thebracket added this to the v1.5 Beta milestone May 20, 2024
@thebracket thebracket requested a review from rchac May 20, 2024 13:44
@thebracket thebracket self-assigned this May 20, 2024
@thebracket thebracket merged commit 17fb5e1 into develop May 30, 2024
2 of 4 checks passed
@thebracket thebracket deleted the preflight-bridge-check branch May 30, 2024 15:11
@rchac rchac mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchac rchac rchac approved these changes

Assignees

@thebracket thebracket

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.5 Beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thebracket @rchac