Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lts cake import2 #484

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Lts cake import2 #484

wants to merge 3 commits into from

Conversation

thebracket
Copy link
Collaborator

Fixes the currently broken LTS Cake queue stats exporter:

  • ECN Marks were being gathered incorrectly, leading to the false assumption that there weren't any the majority of the time.
  • Zero drop/mark events were being reported, significantly bloating the output.
  • Significantly reduced the frequency of the queue poll, because it has a regular impact on CPU and was sending far too much data.

This is a draft pull request, I didn't mean to request review yet - wanted to make sure the issue and progress was logged.

@thebracket
Correctly gather ECN marks from the tins rather than the top-level an…
53e5611 
…d sum them. Remove zero entry items from the Cake stats. This should trim the size of Cake storage a bit, but isn't the full picture yet.
@thebracket
Further improvement - return None if there are no non-zero stats on t…
ba69471 
…his round.
@thebracket
Only update Cake stats infrequently because there tend to be a lot of…
d046287 
… them.
@thebracket thebracket added the bug Something isn't working label May 14, 2024
@thebracket thebracket added this to the v1.5 Beta milestone May 14, 2024
@thebracket thebracket requested a review from rchac May 14, 2024 18:43
@thebracket thebracket self-assigned this May 14, 2024
@dtaht
Copy link
Collaborator

dtaht commented Jun 2, 2024

Thank you for addressing this. Someday I would have time for science again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchac rchac Awaiting requested review from rchac

Assignees

@thebracket thebracket

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.5 Beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thebracket @dtaht