Main #435
Open
Main #435
+122
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehrbrodt
requested changes
Apr 6, 2023
| @@ -42,23 +42,23 @@ | |||
| <attribute name="m2e-apt" value="true"/> | |||
There was a problem hiding this comment.
Please revert changes in this file.
| public AttachDatasource(Map<String, Datasource> nameToDatasource, ConfigThingy sourceDesc, | ||
| URL context) | ||
|
|
||
| public AttachDatasource(Map<String, Datasource> nameToDatasource, ConfigThingy sourceDesc, URL context) |
There was a problem hiding this comment.
Why are code changes included here?
| @@ -190,9 +193,10 @@ public List<String> getSchema() | |||
|
|
|||
| /* | |||
| * (non-Javadoc) | |||
| * | |||
| * | |||
There was a problem hiding this comment.
Please no whitespace changes
| @@ -37,23 +37,23 @@ | |||
| <attribute name="m2e-apt" value="true"/> | |||
| </attributes> | |||
| </classpathentry> | |||
There was a problem hiding this comment.
Please revert changes here
| public QueryResults transform(QueryResults qres) | ||
| { | ||
| return new TranslatedQueryResults(qres); | ||
| } | ||
|
|
||
| /** | ||
| * Stellt die Spalten eines Datasets als Values zur Verfügung. | ||
| * Provides the columns of a dataset as values. |
There was a problem hiding this comment.
Values in uppercase (Interface name)
| @@ -23,11 +23,6 @@ | |||
| <attribute name="maven.pomderived" value="true"/> | |||
| </attributes> | |||
| </classpathentry> | |||
|
Quick ping, still working on this PR? If a bit of support would be useful, to untangle the unrelated changes, please let us know! |
thorstenb
force-pushed
the
main
branch
2 times, most recently
from
5632e2d
to
c721649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed comment from German to English in following three files :