Make sure you can view your moderated deleted and removed communities. #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dessalines
commented
Jul 21, 2024
- The front end checks to see whether you are a mod, in order to be able to restore deleted / removed communities. This removes a filter which prevents that.
- Fixes Deleted communities can't be restored after page reload #4911
- The front end checks to see whether you are a mod, in order to be able to restore deleted / removed communities. This removes a filter which prevents that. - Fixes #4911
SleeplessOne1917
approved these changes
Jul 21, 2024
dullbananas
requested changes
Jul 21, 2024
|
K fixed. It adds some annoying complication, but it works. |
dullbananas
reviewed
Jul 22, 2024
| pool: &mut DbPool<'_>, | ||
| person_id: PersonId, | ||
| is_authenticated: bool, | ||
| local_user: Option<&'a LocalUser>, |
There was a problem hiding this comment.
Try removing the 'a lifetime. It should not be needed
dullbananas
reviewed
Jul 22, 2024
| .select((community::all_columns, person::all_columns)) | ||
| .into_boxed(); | ||
| if !is_authenticated { | ||
|
|
||
| if local_user.is_none() { |
There was a problem hiding this comment.
Use the LocalUserOptionHelper::visible_communities_only method
Nutomic
approved these changes
Jul 23, 2024
dullbananas
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.