Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复异步API获取假日导致全局假日变量初始化未能获取假日的bug #86

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

iporer
Copy link
Contributor

@iporer iporer commented Sep 29, 2020

修复假日API改成异步造成的bug @giscafer

@iporer iporer closed this Sep 29, 2020
@iporer iporer reopened this Sep 29, 2020
@giscafer
Copy link
Member

嗯,这个bug确实没注意到。我以为你说的是 extension.ts 下的异步问题。https://github.com/giscafer/leek-fund/blob/699f84cb3871b9b1b2cbd2018d1f3842f7f22b79/src/extension.ts#L34

这个会遇到在节假日激活插件的时候,可能异步的问题,先请求了一两次接口,如果用户电脑是网络代理的情况下,会有报错信息(股票接口代理下访问不了);如果不是代理,其实也可以正常这样解决假期问题的。

@giscafer
Copy link
Member

@gordongxm 相关代码,at 告知了解一下这个。

@giscafer giscafer merged commit 357b39b into LeekHub:master Sep 29, 2020
@iporer iporer deleted the fix-holiday-init branch September 29, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants