Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leafish: RUST EDITION Title Banner Submission #115

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

IdleEndeavor
Copy link
Contributor

@IdleEndeavor IdleEndeavor commented Sep 7, 2021

Here's the Colour Palette:

  • #4ee005
  • #2a2526
  • #0afe3f
  • #010201
  • #377f62

I've also added a simple logo to be used in the ReadMe file. I saw that the current logo sits higher than the text. So we might as well make that look better. It didn't take much work. Just some text in the 'Minecraft Ten' font

@PureTryOut
Copy link
Collaborator

Looks good! You can remove the .png, besides it being awfully huge pixel-wise it's also... vague? Grainy? And you also added a SVG version if it which is more useful anyway.

The README logo also looks good, thanks for that one!

Why was resources/assets/leafish/logo/leafish-logo.svg re-added? It already exists in the repo.

@IdleEndeavor
Copy link
Contributor Author

Looks good! You can remove the .png, besides it being awfully huge pixel-wise it's also... vague? Grainy? And you also added a SVG version if it which is more useful anyway.

The README logo also looks good, thanks for that one!

Why was resources/assets/leafish/logo/leafish-logo.svg re-added? It already exists in the repo.

I shall remove the PNG
I didn't add the logo again, it just sort of assumes. I don't know what that's about.

@PureTryOut
Copy link
Collaborator

Maybe your branch is just out of date and it didn't include the logo yet. You can rebase it on the main branch and see if it gets rid of the commit.

@IdleEndeavor
Copy link
Contributor Author

I have removed the PNG version
you can merge it now

@PureTryOut
Copy link
Collaborator

And now so you learn Git, please squash the commits into one 😉 https://git-rebase.io can help you out.

Maybe also reword that commit to something like Add "Leafish: Rust edition" title banner

@IdleEndeavor
Copy link
Contributor Author

Please help me
I will die of a heart attack if I try to figure this out any further.
Is there no way to move forward without squashing the commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants