Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore compatibility with pytest #921

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Restore compatibility with pytest #921

merged 3 commits into from
Nov 20, 2019

Conversation

f0k
Copy link
Member

@f0k f0k commented Nov 20, 2019

pytest has deprecated using a [pytest] section in setup.cfg; it only supports [tool:pytest] now. This causes Travis builds to fail. We could either fix pytest to an old version in requirements-dev.txt, or fix setup.cfg -- this PR chooses the latter.

Furthermore, the default format for printing floating point arrays has changed in numpy; there was an additional leading space in front of every number in earlier versions. This causes one of the doctests to fail. Again, we could either fix a particular numpy dependency or fix the doctest. This PR chooses the latter, setting the formatting options inside the doctest (the NORMALIZE_WHITESPACE flag is not enough because it does not cover the change from [ 1.0 to [1.0).

@f0k
Copy link
Member Author

f0k commented Nov 20, 2019

Tests now fail because we pinned Theano==0.8.2, but use the latest version of numpy, and numpy >= 1.16 requires Theano>=1.0.4: Theano/Theano#6671
We could simply change requirements to Theano>=0.8.2. We could also pin Theano==1.0.4, but Lasagne itself is compatible with earlier versions.

@f0k f0k merged commit 5d3c63c into Lasagne:master Nov 20, 2019
@f0k f0k deleted the fix-pytest-cfg branch November 20, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant