Catch exception by Theano 0.10+ on importing theano.sandbox.cuda #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point after removing
theano.sandbox.cuda
, Theano opted to raise anose.SkipTest
exception instead of anImportError
when trying to import it. Some checks in Lasagne were still expecting anImportError
whentheano.sandbox.cuda
was not available. To avoid introducing a dependency onnose
, this PR changes those checks to catch a genericException
. This might mask other exceptions for users of Theano 0.8/0.9 trying to get CUDA to run, but avoids misleading exceptions for users of Theano 0.10. Seems that's the best we can do (without introducing a dependency onnose
or checking the exception class name).