better error message for cuda_convnet import #882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0k
requested changes
Sep 15, 2017
lasagne/layers/cuda_convnet.py
Outdated
| # check if Theano's old GPU backend is available and in use | ||
| try: | ||
| from theano.sandbox.cuda.basic_ops import gpu_contiguous | ||
| except: |
There was a problem hiding this comment.
Should be except ImportError. A naked except: will even catch a CTRL+C by the user.
lasagne/layers/cuda_convnet.py
Outdated
| try: | ||
| from theano.sandbox.cuda.basic_ops import gpu_contiguous | ||
| except: | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
I guess we should raise an ImportError instead.
lasagne/layers/cuda_convnet.py
Outdated
| "cuda_convnet is not supported under Theano's new GPU backend. " | ||
| "Ordinary convolutional or pooling convolutional and pooling layers " | ||
| "can be used (they are usually faster). Also you can downgrade " | ||
| "Theano to version 0.9 and use its old GPU backend)") |
There was a problem hiding this comment.
Should be a period (.) instead of the mismatched closing bracked ()).
lasagne/layers/cuda_convnet.py
Outdated
| from theano.sandbox.cuda.basic_ops import gpu_contiguous | ||
| # check if Theano's old GPU backend is available and in use | ||
| try: | ||
| from theano.sandbox.cuda.basic_ops import gpu_contiguous |
There was a problem hiding this comment.
This doesn't check whether it's in use. import lasagne.layers.cuda_convnet should also fail on Theano 0.8 or 0.9 with device=cuda, not only on Theano 0.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #866.