Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix install error #198

Closed
wants to merge 1 commit into from
Closed

Conversation

JohnBlood
Copy link
Contributor

This change fixes an error where the language file fails to install for Gedit 4 on Fedora 35. This reflects Gedit's move from GTK3 to GTK4.

This change fixes an error where the language file fails to install for Gedit 4 on Fedora 35. This reflects Gedit's move from GTK3 to GTK4.
@JohnBlood
Copy link
Contributor Author

Quick note: I'm not sure if Gedit 4 is available on distros other than Fedora. (The about page says that it is version 4.1 Alpha.) Also, as far as I can tell, Pluma has not been updated to GTK4. It might be a good idea to wait until Gedit 4 is released.

@JohnBlood JohnBlood changed the title update to fix iinstall error Update to fix install error Jan 30, 2022
@Oppen
Copy link

Oppen commented May 13, 2022

Wouldn't this patch break install for users of the older version?

@JohnBlood
Copy link
Contributor Author

Wouldn't this patch break install for users of the older version?

I think it might. Maybe it would be a better Idea to have the script check to see what version of Gedit is installed and continue the installation based on that. That's beyond my skill.

@Oppen
Copy link

Oppen commented May 24, 2022

Is the script run manually? If so, maybe just copy paste and have two of them. It's a one liner, so it should be a problem.

@Lartu
Copy link
Owner

Lartu commented Jun 5, 2022

Hi there! Yes, maybe having two of them would be the easiest solution, as they are ran manually. I'd create a gedit4 folder with the file inside and call it a day!

@Lartu
Copy link
Owner

Lartu commented Nov 30, 2022

Hi there, maybe we could move this to its own repository? 🤔
Please see #207.

@Lartu Lartu closed this Dec 3, 2022
@Lartu
Copy link
Owner

Lartu commented Dec 3, 2022

Sorry for closing this issue! I'd rather have a separate repository for highlighting files. This repo has become too big in the past and we are trying to avoid that. It gets too confusing. Sorry! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants