Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en, ru] Added translation of new phrases in Jetstream #1393

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[en, ru] Added translation of new phrases in Jetstream #1393

merged 1 commit into from
Oct 5, 2020

Conversation

@andrey-helldar
Copy link
Member Author

@Laravel-Lang/laravel-lang, guys, I think this PR will be accepted, so I added new keys for Jetstream.

@luisprmat
Copy link
Member

I think we are going ahead, let's wait what Taylor thinks although I think it's good that this PR is merged

@andrey-helldar
Copy link
Member Author

andrey-helldar commented Oct 4, 2020

Merged 1 hour ago.

image

@andrey-helldar
Copy link
Member Author

I think we are going ahead, let's wait what Taylor thinks although I think it's good that this PR is merged

I agree that it is not worth adding the translation to unaccepted PRs. But in this I personally was sure that they would accept it, since it does not break backward compatibility and implements the translation of phrases.

@caouecs caouecs merged commit 8bc6086 into Laravel-Lang:master Oct 5, 2020
@caouecs
Copy link
Member

caouecs commented Oct 5, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants