Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable auto prefix type and signed url service auto prefix #52

Conversation

veselin-angelov
Copy link
Contributor

Description

Fixed the type of disableAutoPrefix property. Also added support for auto prefix in signed url service.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests
  • E2E tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

MartinAndreev
MartinAndreev previously approved these changes Jan 2, 2024
MartinAndreev
MartinAndreev previously approved these changes Jan 2, 2024
@MartinAndreev MartinAndreev added bug Something isn't working enhancement New feature or request labels Jan 2, 2024
@MartinAndreev MartinAndreev added this to In progress in NestJS s3 package via automation Jan 2, 2024
NestJS s3 package automation moved this from In progress to Review in progress Jan 2, 2024
@veselin-angelov veselin-angelov force-pushed the fix/signed-url-service-and-auto-prefix branch from 1b1f900 to 0c21ff3 Compare January 2, 2024 13:12
@MartinAndreev MartinAndreev merged commit febaef2 into LabO8:master Jan 2, 2024
1 check failed
NestJS s3 package automation moved this from Review in progress to Done Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants