Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ ✨ [hk] added hotkey for collecting easter eggs #2542

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

aallen92
Copy link
Contributor

What kind of update does this PR provide? Please check

  • new translations / updated translations / translation fixes
  • a new feature
  • a new module
  • a bugfix for an existing feature / module
  • improvement of style or user experience
  • other: Please fill out

Which language(s) did you add/update translations for?
use the xx_XX notation for exact language!

  • cs_CZ
  • de_DE
  • en_AU
  • en_GB
  • en_US
  • es_ES
  • fi_FI
  • fr_FR
  • nb_NO
  • nl_NL
  • pl_PL
  • sv_SE

What is included in your update?

  • Added hotkey for collecting easter eggs
  • Added translation for all existing hotkey translations

Additional notes
Please add any further notes here!

@jxn-30
Copy link
Member

jxn-30 commented Aug 19, 2023

@LSS-Manager deploy

@github-actions
Copy link

πŸ‘οΈ I have successfully deployed a build 4.7.7+20230819.2026 on pr2542!

@aallen92 aallen92 requested a review from jxn-30 August 19, 2023 18:56
@Cr4zyc4k3 Cr4zyc4k3 added the enhancement New feature or request label Aug 19, 2023
@Cr4zyc4k3
Copy link
Collaborator

Cr4zyc4k3 commented Aug 19, 2023

I'm not quite sure, whether this is allowed by ToS.

@jxn-30
Copy link
Member

jxn-30 commented Aug 19, 2023

I'm not quite sure, whether this is allowed by ToS.

where is the difference between pressing a key on your keyboard and using a mouse click? That would basically make the whole module be agains ToS as it mostly is only a "click a button / element when pressing this key".

@Cr4zyc4k3
Copy link
Collaborator

Eg. the easter eggs are "hidden" on the whole page. It would destroy the whole "searching experience" (Dunno how to call it) if you just need to press a button instead of "searching" for the eggs.

@aallen92
Copy link
Contributor Author

Eg. the easter eggs are "hidden" on the whole page. It would destroy the whole "searching experience" (Dunno how to call it) if you just need to press a button instead of "searching" for the eggs.

I guess I felt ok with it because they are always in the same position next to the mission title. Spotting it and pressing a hotkey felt the same as spotting it and moving the mouse to click it. That said you guys will know the ToS better than I do!

@jxn-30
Copy link
Member

jxn-30 commented Aug 19, 2023

In my eyes it would be fine with ToS but let's put this on hold and ask the game devs, just to be sure!

@jxn-30 jxn-30 added the awaiting game approving A critical idea that needs to be confirmed by Game-Devs label Aug 19, 2023
@deoxis9001
Copy link
Contributor

fr_FR:
"Collecter un objet saisonnier (par ex. un Ε“uf de PΓ’ques)"

@jxn-30
Copy link
Member

jxn-30 commented Aug 22, 2023

In my eyes it would be fine with ToS but let's put this on hold and ask the game devs, just to be sure!

The team confirmed that this hotkey is fine!

@jxn-30 jxn-30 removed the awaiting game approving A critical idea that needs to be confirmed by Game-Devs label Aug 22, 2023
@aallen92
Copy link
Contributor Author

The team confirmed that this hotkey is fine!

That's good news! I'll try and get the amendments to the label done in the next day or so in that case

@jxn-30 jxn-30 enabled auto-merge August 23, 2023 11:47
@jxn-30 jxn-30 merged commit 0555c7b into LSS-Manager:dev Aug 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants