This repository has been archived by the owner on May 6, 2024. It is now read-only.
fixup string manipulation for scoring planes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do two things with the input subsystem name: 1. We capitalize the first letter and then append 'ScoringPlaneHits' to be the collection name 2. We prepend 'sp_' to be the match substring for logical volumes This means the input subsystem is the name of the scoring planes in the GDML with the 'sp_' prefix removed.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do two things with the input subsystem name:
be the collection name
This means the input subsystem is the name of the scoring planes in the
GDML with the 'sp_' prefix removed.