Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM64 build #95

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Support ARM64 build #95

merged 1 commit into from
Jul 11, 2022

Conversation

somnisomni
Copy link
Contributor

This pull request will make the app could be built for ARM64 architecture by adding Configurations and Publish Profiles.

@Kyome22
Copy link
Owner

Kyome22 commented Jul 4, 2022

@somnisomni
If I merge this PR, do I need to use Visual Studio 2022? (I use Visual Studio 2019 now.)
And, my ThinkPad is probably not ARM64 but is it ok?

@Kyome22
Copy link
Owner

Kyome22 commented Jul 4, 2022

Also, Is it no problem if I merge #97 ?

@somnisomni
Copy link
Contributor Author

somnisomni commented Jul 4, 2022

I think you don't need to update your Visual Studio, the ARM64 build support was included since VS2017 (as far as I searched). .NET 5 also supports ARM64 build, so there will be no hassle.

and no need to have ARM64 machine to build ARM64 executables. It should be built without any problem on x86-based machines. (but may have to test on virtual machine...?)

Just ignore about VisualStudioVersion. or maybe I can remove the changes of it if you want.

#97 has no problem to merge I think.

@Kyome22
Copy link
Owner

Kyome22 commented Jul 5, 2022

@somnisomni
OK!
I want to confirm that these pull requests will work well and merge #95 and #97 over the weekend.

@Kyome22 Kyome22 merged commit d6bf52e into Kyome22:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants