Skip to content

Commit

Permalink
refactor: remove cmp-spell and omnifunc
Browse files Browse the repository at this point in the history
  • Loading branch information
@KyleKing
KyleKing committed Feb 23, 2024
1 parent 85ce3b4 commit f3e92a6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 22 deletions.
15 changes: 6 additions & 9 deletions .github/CODE_TAG_SUMMARY.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,12 @@
| PLANNED | also consider 0p, but figure out how these can be useful first | 2024-02-02 | [lua/kyleking/keymaps.lua:17](https://github.com/KyleKing/nvim/blame/8d001f9096ea0084121918861a97b859310cf59a/lua/kyleking/keybinds.lua#L14) |
| PLANNED | K("n", "<leader>pa", function() require("astrocore").update_packages() end, { desc = "Update Lazy and Mason" }) | 2024-02-05 | [lua/kyleking/keymaps.lua:49](https://github.com/KyleKing/nvim/blame/3fd0d95ef92eff615863f857b0195fa26a1d66e9/lua/kyleking/keybinds.lua#L49) |
| PLANNED | review these additional keybinds | 2024-02-01 | [lua/kyleking/keymaps.lua:67](https://github.com/KyleKing/nvim/blame/e25faf56d74fed989793595dded50559262bfbd6/lua/kyleking/keybinds.lua#L57) |
| PLANNED | consider additional sources: https://github.com/hrsh7th/nvim-cmp/wiki/List-of-sources | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:18](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L18) |
| PLANNED | revisit completions for commands | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:80](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L80) |
| PLANNED | consider https://github.com/f3fora/cmp-spell | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:98](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L98) |
| PLANNED | Source: omni (and see both commented snippets above) | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:102](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L102) |
| PLANNED | use async_path instead from: https://github.com/FelipeLema/cmp-async-path) | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:103](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L103) |
| PLANNED | consider https://github.com/quangnguyen30192/cmp-nvim-ultisnips | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:112](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/completions/nvim-cmp.lua#L112) |
| PLANNED | consider additional sources: https://github.com/hrsh7th/nvim-cmp/wiki/List-of-sources | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:18](https://github.com/KyleKing/nvim/blame/2c93cec269fc0dbc03769d963656d69173b824a2/lua/kyleking/plugins/completions/nvim-cmp.lua#L18) |
| PLANNED | revisit completions for commands | 2024-02-21 | [lua/kyleking/plugins/completions/nvim-cmp.lua:78](https://github.com/KyleKing/nvim/blame/2c93cec269fc0dbc03769d963656d69173b824a2/lua/kyleking/plugins/completions/nvim-cmp.lua#L80) |
| PLANNED | Consider using the TS comment grammar instead: https://github.com/stsewd/tree-sitter-comment | 2024-02-12 | [lua/kyleking/plugins/editing-support/todo-comments.lua:1](https://github.com/KyleKing/nvim/blame/afdadc7719111e1e44e3a61cc0bad3583381a498/lua/kyleking/plugins/editing-support/todo-comments.lua#L1) |
| FIXME | support python! | 2024-02-15 | [lua/kyleking/plugins/formatting/conform.lua:1](https://github.com/KyleKing/nvim/blame/dc4dfe091ed5d10f2194407c2fb6df7de0ea3f2f/lua/kyleking/plugins/formatting/conform.lua#L1) |
| PLANNED | use local mdformat if present | 2024-02-21 | [lua/kyleking/plugins/formatting/conform.lua:25](https://github.com/KyleKing/nvim/blame/39dd77e1b5ebfdd2aab3f410cd3bc9eb0f341a5a/lua/kyleking/plugins/formatting/conform.lua#L25) |
| PLANNED | use local mdformat if present | 2024-02-21 | [lua/kyleking/plugins/formatting/conform.lua:25](https://github.com/KyleKing/nvim/blame/460347eae7782ef4ce5ce16009f66ad71633ce38/lua/kyleking/plugins/formatting/conform.lua#L25) |
| PLANNED | replace with ruff format | 2024-02-21 | [lua/kyleking/plugins/formatting/conform.lua:27](https://github.com/KyleKing/nvim/blame/460347eae7782ef4ce5ce16009f66ad71633ce38/lua/kyleking/plugins/formatting/conform.lua#L27) |
| PLANNED | should injected errors be ignored? | 2024-02-21 | [lua/kyleking/plugins/formatting/conform.lua:44](https://github.com/KyleKing/nvim/blame/39dd77e1b5ebfdd2aab3f410cd3bc9eb0f341a5a/lua/kyleking/plugins/formatting/conform.lua#L44) |
| PLANNED | replace pint and dprint examples with project-specific eslint formatting from node_modules closest to file | 2024-02-11 | [lua/kyleking/plugins/formatting/conform.lua:70](https://github.com/KyleKing/nvim/blame/d537dbaf04e1a1de826d0b9bbc42766c5c2016be/lua/kyleking/plugins/formatting/conform.lua#L64) |
| PLANNED | investigate these go-to mappings | 2024-02-07 | [lua/kyleking/plugins/fuzzy-finder/telescope.lua:106](https://github.com/KyleKing/nvim/blame/5d8eb1c4cfde1b2d7937e2483b656c32fc2bfc37/lua/kyleking/plugins/fuzzy-finder/telescope.lua#L106) |
Expand All @@ -28,7 +25,7 @@
| PLANNED | (Investigate) Enable completion triggered by <c-x><c-o> (note: lsp-zero has some logic for this internally that this may duplicate) | 2024-02-11 | [lua/kyleking/plugins/lsp/lsp-zero.lua:35](https://github.com/KyleKing/nvim/blame/27b19486b8cc6eb341ce43ee984128d3a9ab74d9/lua/kyleking/plugins/lsp/lsp-zero.lua#L93) |
| PLANNED | consider using the LSP-Zero variants (LspZeroWorkspaceRemove, etc.) | 2024-02-12 | [lua/kyleking/plugins/lsp/lsp-zero.lua:73](https://github.com/KyleKing/nvim/blame/9b8a9e6c99f97695e01ac706be83fb5ff165c555/lua/kyleking/plugins/lsp/lsp-zero.lua#L68) |
| FIXME | support python! | 2024-02-15 | [lua/kyleking/plugins/lsp/lsp-zero.lua:102](https://github.com/KyleKing/nvim/blame/dc4dfe091ed5d10f2194407c2fb6df7de0ea3f2f/lua/kyleking/plugins/lsp/lsp-zero.lua#L108) |
| PLANNED | see configuration in mason.lua | 2024-02-21 | [lua/kyleking/plugins/lsp/lsp-zero.lua:199](https://github.com/KyleKing/nvim/blame/main/lua/kyleking/plugins/lsp/lsp-zero.lua#L199) |
| PLANNED | see configuration in mason.lua | 2024-02-21 | [lua/kyleking/plugins/lsp/lsp-zero.lua:199](https://github.com/KyleKing/nvim/blame/2c93cec269fc0dbc03769d963656d69173b824a2/lua/kyleking/plugins/lsp/lsp-zero.lua#L199) |
| FIXME | Split these back up into separate files | 2024-02-15 | [lua/kyleking/plugins/lsp/lsp-zero.lua:208](https://github.com/KyleKing/nvim/blame/c5fd0f3f748028c54222887eaa2dce0b4ef1d7f7/lua/kyleking/plugins/lsp/lsp-zero.lua#L321) |
| PLANNED | look at customization: https://github.com/mfussenegger/nvim-lint/issues/532#issue-2126623239 | 2024-02-21 | [lua/kyleking/plugins/lsp/nvim-lint.lua:11](https://github.com/KyleKing/nvim/blame/39dd77e1b5ebfdd2aab3f410cd3bc9eb0f341a5a/lua/kyleking/plugins/lsp/nvim-lint.lua#L11) |
| PLANNED | configure flake8/mypy/etc. based on existence in .venv | 2024-02-21 | [lua/kyleking/plugins/lsp/nvim-lint.lua:17](https://github.com/KyleKing/nvim/blame/39dd77e1b5ebfdd2aab3f410cd3bc9eb0f341a5a/lua/kyleking/plugins/lsp/nvim-lint.lua#L17) |
Expand All @@ -43,6 +40,6 @@
| TODO | load JSON, see if key is present (key is basename of current directory, e.g. mdformat-mkdocs), and check for pythonPath | 2024-02-09 | [lua/kyleking/utils/system_utils.lua:28](https://github.com/KyleKing/nvim/blame/167332a44724e01be0b03794eeee3a0cd470c7de/lua/kyleking/utils/system_utils.lua#L28) |
| PLANNED | consider SemGrep rule for require() or not (e.g. the initial install will fail when telescope isn't available) | 2024-02-01 | [run-semgrep.sh:10](https://github.com/KyleKing/nvim/blame/30f6d29da1ecdcc7f9ede368241a121b843bf2b8/run-semgrep.sh#L10) |

Found code tags for FIXME (3), TODO (5), PLANNED (32)
Found code tags for FIXME (3), TODO (5), PLANNED (29)

<!-- calcipy_skip_tags -->
4 changes: 3 additions & 1 deletion lazy-lock.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
"auto-session": { "branch": "main", "commit": "29a8c77a0579636d5520aebd38bdbc2e6079f2f5" },
"bufdelete.nvim": { "branch": "master", "commit": "0b9c0f182b09c51170bb9f252f15de7695e4d507" },
"ccc.nvim": { "branch": "main", "commit": "ec6e23fd2c0bf4ffcf71c1271acdcee6e2c6f49c" },
"cmp-async-path": { "branch": "main", "commit": "6eeaf0f3968ea1e6f135a5ee5aa01828f66611a5" },
"cmp-buffer": { "branch": "main", "commit": "3022dbc9166796b644a841a02de8dd1cc1d311fa" },
"cmp-nvim-lsp": { "branch": "main", "commit": "5af77f54de1b16c34b23cba810150689a3a90312" },
"cmp-nvim-lsp-signature-help": { "branch": "main", "commit": "3d8912ebeb56e5ae08ef0906e3a54de1c66b92f1" },
"cmp-nvim-lua": { "branch": "main", "commit": "f12408bdb54c39c23e67cab726264c10db33ada8" },
"cmp-path": { "branch": "main", "commit": "91ff86cd9c29299a64f968ebb45846c485725f23" },
"cmp-spell": { "branch": "master", "commit": "32a0867efa59b43edbb2db67b0871cfad90c9b66" },
"cmp_luasnip": { "branch": "master", "commit": "05a9ab28b53f71d1aece421ef32fee2cb857a843" },
"cmp_yanky": { "branch": "main", "commit": "c3d089186ccead26eba01023502f3eeadd7a92d2" },
"colorful-winsep.nvim": { "branch": "main", "commit": "e1b72c498f25c1fc37a7e9913332c137f753a90a" },
"conform.nvim": { "branch": "master", "commit": "b8624e46d83c8b59e5d4a773bdcae6ffc3b9639a" },
"dial.nvim": { "branch": "master", "commit": "27eb570085db2ef44bff4f620d3806039184651c" },
Expand Down
12 changes: 0 additions & 12 deletions lua/kyleking/plugins/completions/nvim-cmp.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@ local function config_cmp()
{ name = "cmp_yanky" },
}, {
-- Reduce false positives by placing these in the secondary completions category
-- {
-- name = "omni",
-- option = { disable_omnifuncs = { "v:lua.vim.lsp.omnifunc" } },
-- },
{
name = "spell",
option = {
enable_in_context = function() return require("cmp.config.context").in_treesitter_capture("spell") end,
},
},
{ name = "buffer", keyword_length = 3 },
}),
completion = {
Expand Down Expand Up @@ -104,12 +94,10 @@ return {
{ "VonHeikemen/lsp-zero.nvim" }, -- Configured in plugins.lsp.lsp-zero
-- Sources
{ "hrsh7th/cmp-nvim-lsp" }, -- Source: nvim_lsp
{ "f3fora/cmp-spell" }, -- Source: spell
{ "hrsh7th/cmp-buffer" }, -- Source: buffer
{ "hrsh7th/cmp-nvim-lsp-signature-help" }, -- Source: nvim_lsp_signature_help
{ "hrsh7th/cmp-nvim-lua" }, -- Source nvim_lua
{ "chrisgrieser/cmp_yanky" }, -- Source: cmp_yanky
-- { "hrsh7th/cmp-omni" }, -- PLANNED: Source: omni (and see both commented snippets above)
{
-- "hrsh7th/cmp-path", -- Source: path
"https://codeberg.org/FelipeLema/cmp-async-path", -- Source: async_path
Expand Down

0 comments on commit f3e92a6

Please sign in to comment.