Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI import does not support file paths #690

Closed
cweiske opened this issue Sep 15, 2023 · 2 comments · Fixed by #673
Closed

CLI import does not support file paths #690

cweiske opened this issue Sep 15, 2023 · 2 comments · Fixed by #673
Labels
Bug Something isn't working

Comments

@cweiske
Copy link

cweiske commented Sep 15, 2023

Bug Description

I wanted to import a link collection file with 1600 bookmarks. After failing with the browser-based import I tried the cli.

There I ran:

$ cd  /usr/local/src/linkace/linkace-v1.12.2/
$ ./artisan links:import /tmp/Bookmarks-2023-09-14.html
Error: File does not exist at path /usr/local/src/linkace/linkace-v1.12.2/storage//tmp/Bookmarks-2023-09-14.html

So linkace tried to make the path relative to the storage directory instead of taking the absolute path I gave.

How to reproduce

  1. Put a bookmarks file in /tmp/links.html
  2. Try to import it via cli: ./artisan links:import /tmp/links.html
  3. Get an error that the file does not exist

Expected behavior

Linkace reads the file from the path that I specified.

Logs

No response

Screenshots

No response

LinkAce version

v1.12.2

Setup Method

PHP

Operating System

Linux (Ubuntu, CentOS,...)

Client details

No response

@cweiske cweiske added the Bug Something isn't working label Sep 15, 2023
@cweiske
Copy link
Author

cweiske commented Sep 15, 2023

Also reported at #287 (comment)

@Kovah Kovah linked a pull request Nov 1, 2023 that will close this issue
@Kovah Kovah closed this as completed in #673 Nov 1, 2023
@cweiske
Copy link
Author

cweiske commented Nov 1, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant