Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for tag #309

Closed
gavinr opened this issue Sep 8, 2021 · 5 comments · Fixed by #314
Closed

Search for tag #309

gavinr opened this issue Sep 8, 2021 · 5 comments · Fixed by #314
Labels
Enhancement Any requests for improvements or new features
Milestone

Comments

@gavinr
Copy link
Contributor

gavinr commented Sep 8, 2021

Is your feature request related to a problem? Please describe.
If I have a lot of tags, and I want to see the list of bookmarks associated with that tag, it's hard to find that page since the "all tags" page is paginated.

Describe the solution you'd like
Ability to search or filter on the "All Tags" page

@gavinr gavinr added the Enhancement Any requests for improvements or new features label Sep 8, 2021
@Kovah
Copy link
Owner

Kovah commented Sep 8, 2021

That's a good idea and could be applied to lists too.

@gavinr
Copy link
Contributor Author

gavinr commented Sep 8, 2021

Thanks! I'm happy to support this via a PR if you do not have time.

@Kovah
Copy link
Owner

Kovah commented Sep 8, 2021

Yes please, if you have the time I would love to accept a pr on this. 💚

@gavinr
Copy link
Contributor Author

gavinr commented Sep 8, 2021

Great, what would you like the UI to look like? Something like this?

image

@Kovah
Copy link
Owner

Kovah commented Sep 8, 2021

I would place it to the left of the button on the same line, maybe without the "search" on the button to keep it small.

@Kovah Kovah linked a pull request Sep 13, 2021 that will close this issue
@Kovah Kovah added this to the v1.7.0 milestone Sep 13, 2021
Kovah added a commit that referenced this issue Sep 20, 2021
@Kovah Kovah closed this as completed in #314 Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants