Do not probabilistically steal blocking tasks as part of anti-starvat… #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
approved these changes
Dec 17, 2018
| parkedWorkersStackPush(this) | ||
| if (!blockingQuiescence()) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
^ Code style: Format those "quick returns" without curly braces, especially since if (!blockingQuiescence()) return is one-liner in two other places).
…ion mechanism: stealing thread might be woken up in `blockingQuiescence` and already have a blocking task in its local queue
c4f880b
to
cf1cbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion mechanism: stealing thread might be woken up in
blockingQuiescenceand already have a blocking task in its local queue