Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-structure DebugProbes documentation and mention classloading #4024

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

qwwdfsad
Copy link
Collaborator

Fixes #4000

* updated on each suspension and resumption.
* * If [DebugProbes.enableCreationStackTraces] is enabled, stack trace of the current thread is captured on
* - If [DebugProbes.enableCreationStackTraces] is enabled, stack trace of the current thread is captured on
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we mention' KDoc' from time to time, I'd like to hear your opinion here.

WDYT about making dashes the recommended (notably: KDoc spec, our libraries, IDEAs autoformatter and quickfixes) way for unordered lists instead of asterisks? I find it slightly more approachable than multiple asterisks (because of the one required by KDoc itself) especially when multiple levels of nesting are involved

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure: #4027

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
* updated on each suspension and resumption.
* * If [DebugProbes.enableCreationStackTraces] is enabled, stack trace of the current thread is captured on
* - If [DebugProbes.enableCreationStackTraces] is enabled, stack trace of the current thread is captured on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure: #4027

Co-authored-by: Dmitry Khalanskiy <[email protected]>
@qwwdfsad qwwdfsad merged commit 648ba8a into develop Jan 29, 2024
1 check was pending
@qwwdfsad qwwdfsad deleted the debugger-cl-docs branch January 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants