Wasm target implementation #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoriakovlev
force-pushed
the
wasm_develop
branch
2 times, most recently
from
2a385fd
to
646c32e
Compare
qwwdfsad
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Please provide a detailed description of the PR as one would do for other Kotlin subsystems:
- Briefly explain what exactly is done in the scope of the PR
- Including new targets, publication structure and what is left to do
- If the code has any explicit or implicit TODOs or leftovers, please spell them out
- If the PR contains any non-trivial parts that are hard to understand without diving too deep -- please explain them
- Example 1: PR is red on the CI, cannot be built or imported. Nothing in the PR indicates why so and when should we proceed
- Example 2: PR has some number of copy-pasted code (which is twice the maintenance and divergence bugs) but no explanation why so and whether there is anything that prevents us from avoiding doing so
- Example 3: there are innocuously-looking tests that are ignored without any explanation
- Example 4: Dokka documentation apparently generates links that point to a branch different from master?
kotlinx-coroutines-core/jsWasm/src/flow/internal/SafeCollector.kt
Outdated
Show resolved
Hide resolved
igoriakovlev
force-pushed
the
wasm_develop
branch
5 times, most recently
from
b4ab8d6
to
4f41090
Compare
qwwdfsad
requested changes
Sep 11, 2023
qwwdfsad
reviewed
Sep 14, 2023
igoriakovlev
force-pushed
the
wasm_develop
branch
from
45aa414
to
7eb99f7
Compare
igoriakovlev
commented
Sep 15, 2023
igoriakovlev
force-pushed
the
wasm_develop
branch
from
0d98f08
to
49d24e3
Compare
igoriakovlev
force-pushed
the
wasm_develop
branch
2 times, most recently
from
6bbdca8
to
432af04
Compare
This was referenced Nov 15, 2023
igoriakovlev
force-pushed
the
wasm_develop
branch
from
b959381
to
bfd2bce
Compare
qwwdfsad
force-pushed
the
wasm_develop
branch
from
bfd2bce
to
5142adb
Compare
igoriakovlev
force-pushed
the
wasm_develop
branch
from
5142adb
to
dce81cb
Compare
qwwdfsad
force-pushed
the
wasm_develop
branch
from
dce81cb
to
d0b07a8
Compare
qwwdfsad
approved these changes
Dec 1, 2023
qwwdfsad
force-pushed
the
wasm_develop
branch
from
d0b07a8
to
8a58c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Kotlin/Wasm/JS target implementation for kotlinx.corourines. Mostly this is a port of Kotlin/JS implementation with wasm-related changes, like Kotlin <-> JS interop.
There is dependency to intermediate version to AtomicFU which is not published yet officially into repository. This is why we need atomicFU bootstrap version 0.21.0-wasm0 in wasm experimental repo.
There a lit of similar code with JS and Native implementations. I have tried my best to combine this code into separate shared directory, but there is some number of copy-pasted code for now which is similar but not the same. I look forward to hear possible solutions to avoid this.
Dokka documentation apparently generates links that point to a branch different from master, because adding similar, but not equal declarations for several targets makes different links, which is not exists in current master.