Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MutexCancellationStressTest flakiness #3724

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sponsor of this PR review is the amazing Difftastic tool: https://difftastic.wilfred.me.uk/ Instead of the atrocious results produced by Github or the default git diff or the IntelliJ IDEA diff that is actually much better but still off, I get the completely sensible
2023-04-26T14:09:20,859584239+02:00

@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented Apr 26, 2023

My bad for messing with the diff though, was stressing the test with a hand-rolled loop and this is a leftover. Sorry for the inconvenience

@qwwdfsad qwwdfsad merged commit d6f1403 into develop Apr 26, 2023
@qwwdfsad qwwdfsad deleted the fix-mutex-flaky-test branch April 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants