Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Groovy and Kotlin DSL code snippets #3096

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Unify Groovy and Kotlin DSL code snippets #3096

merged 1 commit into from
Jan 11, 2022

Conversation

mahozad
Copy link
Contributor

@mahozad mahozad commented Dec 17, 2021

Fixes #3095.

Use common syntax where possible.

@qwwdfsad qwwdfsad self-requested a review January 10, 2022 14:58
qwwdfsad
qwwdfsad reviewed Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, thanks for taking care!

Could you please rebase your branch to use recent changes from the README? (namely coroutines version)

@mahozad
Copy link
Contributor Author

mahozad commented Jan 11, 2022

@qwwdfsad Sure, rebased the branch on master.

@mahozad
Unify Groovy and Kotlin DSL code snippets
96a2ba9 
Use common syntax where possible
qwwdfsad
qwwdfsad approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it 👍

@qwwdfsad qwwdfsad merged commit 5a71f7b into Kotlin:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the README a little more consistent and more concise
2 participants
@mahozad @qwwdfsad