Fix reading an uninitialized value of defaultMainDelayOptIn due to in… #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itialization cycle and add a test that ensures this behaviour in the future Fixes #3044
| private val defaultMainDelayOptIn = systemProp("kotlinx.coroutines.main.delay", true) | ||
|
|
||
| internal actual val DefaultDelay: Delay = initializeDefaultDelay() |
There was a problem hiding this comment.
Wow! TIL. This changes everything. I will not be able to forget this.
Now the test module correctly exposes that initially the Main dispatcher is missing, so the default delay mechanism is not rewritten.
woainikk
pushed a commit
that referenced
this pull request
Dec 14, 2021
Fix reading an uninitialized value of defaultMainDelayOptIn due to the initialization cycle and add a test that ensures this behaviour in the future Fixes #3044
yorickhenning
pushed a commit
to yorickhenning/kotlinx.coroutines
that referenced
this pull request
Jan 28, 2022
Fix reading an uninitialized value of defaultMainDelayOptIn due to the initialization cycle and add a test that ensures this behaviour in the future Fixes Kotlin#3044
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Fix reading an uninitialized value of defaultMainDelayOptIn due to the initialization cycle and add a test that ensures this behaviour in the future Fixes Kotlin#3044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…itialization cycle and add a test that ensures this behaviour in the future
Fixes #3044