Optimize mutex implementation #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qwwdfsad
commented
Jul 30, 2021
qwwdfsad
commented
qwwdfsad
commented
Jul 30, 2021
| @@ -352,31 +369,37 @@ internal class MutexImpl(locked: Boolean) : Mutex, SelectClause2<Any?, Mutex> { | |||
| private abstract inner class LockWaiter( | |||
| @JvmField val owner: Any? | |||
| ) : LockFreeLinkedListNode(), DisposableHandle { | |||
| private val isTaken = atomic<Boolean>(false) | |||
There was a problem hiding this comment.
it's possible to avoid this field and use an atomic wrapper over the owner (then it has to be passed between tryResumeLockWaiter and completeResumeLockWaiter), but I found it way too harsh
* Get rid of addLastIf and DCSS primitive during contention
* Leverage constants returned by tryResume* and simplify signatures
elizarov
approved these changes
Aug 2, 2021
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
* Get rid of addLastIf and DCSS primitive during contention * Leverage constants returned by tryResume* and simplify signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.