General cleanup #2809
General cleanup #2809
Conversation
qwwdfsad
commented
Jul 6, 2021
qwwdfsad
commented
- Do not generate Dokka documentation for deprecated members
- Get rid of inline classes notation
- Opt-in into DelicateCoroutineApi in our own project
- Get rid of JVM IR checks that are no longer relevant
…g of JVM IR compiler
| val repositoryId: String? = System.getenv("libs.repository.id") | ||
| return if (repositoryId == null) { | ||
| // Using implicitly created staging, for MPP it's likely to be a mistake because | ||
| // publication on TeamCity will create 3 independent staging repositories | ||
| System.err.println("Warning: using an implicitly created staging for coroutines") |
There was a problem hiding this comment.
I don't understand the changes to this file. They don't affect anything, but still, could you explain them?
There was a problem hiding this comment.
Our library is multiplatform and thus should be published from multiple machines (one per supported K/N architecture).
When we're configuring publication, we have to specify the repository we're going to publish to.
The default recommended/implicitly used address is /staging/deploy/maven2/. When it's used, a new staging repository is created by the Maven plugin. Essentially it means that, when we're publishing from multiple agents, we'll create multiple staging repositories (=> multiple releases with the same version and partial artifacts set).
To avoid that, we preconfigure our builds with a pre-created staging repository and pass its id via libs.repository.id for publishing tasks.
We do not do that for regular builds, but Gradle still configures publishing tasks, so this warning has been printed as many times as we got modules on each Gradle configuration, obfuscating our build output
* Suppress all deprecated signatures from the documentation * Migrate inline classes to value * Get rid of annoying Gradle output when tasks are configured * Opt-in into delicate coroutines API * Get rid of legacy jvm_ir_enabled that was used for pre-release testing of JVM IR compiler * Update README references
